[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block-backend: Silence clang -m32 compiler warning
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] block-backend: Silence clang -m32 compiler warning |
|
Date: |
Tue, 26 Oct 2021 12:31:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/26/21 11:07, Hanna Reitz wrote:
> Similarly to e7e588d432d31ecebc26358e47201dd108db964c, there is a
> warning in block/block-backend.c that qiov->size <= INT64_MAX is always
> true on machines where size_t is narrower than a uint64_t. In said
> commit, we silenced this warning by casting to uint64_t.
>
> The commit introducing this warning here
> (a93d81c84afa717b0a1a6947524d8d1fbfd6bbf5) anticipated it and so tried
> to address it the same way. However, it only did so in one of two
> places where this comparison occurs, and so we still need to fix up the
> other one.
>
> Fixes: a93d81c84afa717b0a1a6947524d8d1fbfd6bbf5
> ("block-backend: convert blk_aio_ functions to int64_t bytes
> paramter")
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> ---
> block/block-backend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>