Re: [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status

[David Hildenbrand]

On 28.10.21 09:56, Jonah Palmer wrote:
> On 10/27/21 08:18, Laurent Vivier wrote:
>> On 27/10/2021 13:59, David Hildenbrand wrote:
>>> On 27.10.21 13:41, Jonah Palmer wrote:
>>>> From: Laurent Vivier <lvivier@redhat.com>
>>>>
>>>> Display feature names instead of bitmaps for host, guest, and
>>>> backend for VirtIODevice.
>>>>
>>>> Display status names instead of bitmaps for VirtIODevice.
>>>>
>>>> Display feature names instead of bitmaps for backend, protocol,
>>>> acked, and features (hdev->features) for vhost devices.
>>>>
>>>> Decode features according to device type. Decode status
>>>> according to configuration status bitmap (config_status_map).
>>>> Decode vhost user protocol features according to vhost user
>>>> protocol bitmap (vhost_user_protocol_map).
>>>>
>>>> Transport features are on the first line. Undecoded bits
>>>> (if any) are stored in a separate field. Vhost device field
>>>> wont show if there's no vhost active for a given VirtIODevice.
>>>>
>>>> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
>>>> ---
>>>>   hw/block/virtio-blk.c          |  28 ++
>>>>   hw/char/virtio-serial-bus.c    |  11 +
>>>>   hw/display/virtio-gpu-base.c   |  18 +-
>>>>   hw/input/virtio-input.c        |  11 +-
>>>>   hw/net/virtio-net.c            |  47 ++++
>>>>   hw/scsi/virtio-scsi.c          |  17 ++
>>>>   hw/virtio/vhost-user-fs.c      |  10 +
>>>>   hw/virtio/vhost-vsock-common.c |  10 +
>>>>   hw/virtio/virtio-balloon.c     |  14 +
>>>>   hw/virtio/virtio-crypto.c      |  10 +
>>>>   hw/virtio/virtio-iommu.c       |  14 +
>>>>   hw/virtio/virtio.c             | 273 ++++++++++++++++++-
>>>>   include/hw/virtio/vhost.h      |   3 +
>>>>   include/hw/virtio/virtio.h     |  17 ++
>>>>   qapi/virtio.json               | 577
>>>> ++++++++++++++++++++++++++++++++++++++---
>>>
>>> Any particular reason we're not handling virtio-mem?
>>>
>>> (there is only a single feature bit so far, a second one to be
>>> introduced soon)
>>>
>>
>> I think this is because the v1 of the series has been written in March
>> 2020 and it has not been update when virtio-mem has been added (June
>> 2020).
>>
>> Thanks,
>> Laurent
> 
> Oops, I think I just might've missed this device. I can add in support for 
> virtio-mem
> in the next revision!

Cool, thanks! I consider the introspection interface very valuable!


-- 
Thanks,

David / dhildenb