Re: [PATCH v9 8/8] hmp: add virtio commands

[Markus Armbruster]

Jonah Palmer <jonah.palmer@oracle.com> writes:

> From: Laurent Vivier <lvivier@redhat.com>
>
> This patch implements the HMP versions of the virtio QMP commands.
>
> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
> ---
>  hmp-commands-info.hx  | 218 ++++++++++++++++++++++++++++++
>  include/monitor/hmp.h |   5 +
>  monitor/hmp-cmds.c    | 358 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 581 insertions(+)
>
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index 407a1da..6bf7359 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -877,3 +877,221 @@ SRST
>    ``info sgx``
>      Show intel SGX information.
>  ERST
> +
> +    {
> +        .name      = "virtio",
> +        .args_type = "",
> +        .params    = "",
> +        .help      = "List all available virtio devices",
> +        .cmd       = hmp_virtio_query,
> +        .flags     = "p",
> +    },
> +
> +SRST
> +  ``info virtio``
> +    List all available virtio devices
> +
> +    Example:
> +
> +    List all available virtio devices in the machine::
> +
> +    (qemu) info virtio
> +    /machine/peripheral/vsock0/virtio-backend [vhost-vsock]

I get

    docs/../hmp-commands-info.hx:899:Inconsistent literal block quoting.

This is from Sphinx.  I can't see what's wrong.

> +    /machine/peripheral/crypto0/virtio-backend [virtio-crypto]
> +    /machine/peripheral-anon/device[2]/virtio-backend [virtio-scsi]
> +    /machine/peripheral-anon/device[1]/virtio-backend [virtio-net]
> +    /machine/peripheral-anon/device[0]/virtio-backend [virtio-serial]
> +
> +ERST

[...]