[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/10] vhost-backend: avoid overflow on memslots_limit
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 05/10] vhost-backend: avoid overflow on memslots_limit |
|
Date: |
Thu, 11 Nov 2021 18:59:43 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/11/21 16:33, Roman Kagan wrote:
> Fix the (hypothetical) potential problem when the value parsed out of
> the vhost module parameter in sysfs overflows the return value from
> vhost_kernel_memslots_limit.
>
> Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
> ---
> hw/virtio/vhost-backend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c
> index b65f8f7e97..44f7dbb243 100644
> --- a/hw/virtio/vhost-backend.c
> +++ b/hw/virtio/vhost-backend.c
> @@ -58,7 +58,7 @@ static int vhost_kernel_memslots_limit(struct vhost_dev
> *dev)
> if (g_file_get_contents("/sys/module/vhost/parameters/max_mem_regions",
> &s, NULL, NULL)) {
> uint64_t val = g_ascii_strtoull(s, NULL, 10);
Would using qemu_strtou64() simplify this?
> - if (!((val == G_MAXUINT64 || !val) && errno)) {
> + if (val < INT_MAX && val > 0) {
> g_free(s);
> return val;
> }
>
- [PATCH 01/10] vhost-user-blk: reconnect on any error during realize, (continued)
[PATCH 03/10] chardev/char-socket: tcp_chr_sync_read: don't clobber errno, Roman Kagan, 2021/11/11
[PATCH 02/10] chardev/char-socket: tcp_chr_recv: don't clobber errno, Roman Kagan, 2021/11/11
[PATCH 05/10] vhost-backend: avoid overflow on memslots_limit, Roman Kagan, 2021/11/11
- Re: [PATCH 05/10] vhost-backend: avoid overflow on memslots_limit,
Philippe Mathieu-Daudé <=
[PATCH 07/10] vhost-vdpa: stick to -errno error return convention, Roman Kagan, 2021/11/11
[PATCH 06/10] vhost-backend: stick to -errno error return convention, Roman Kagan, 2021/11/11
[PATCH 04/10] chardev/char-fe: don't allow EAGAIN from blocking read, Roman Kagan, 2021/11/11
[PATCH 10/10] vhost-user-blk: propagate error return from generic vhost, Roman Kagan, 2021/11/11