Re: [PATCH v4 12/25] assertions for blockob.h global state API

[Hanna Reitz]

Subject: s/blockob.h/blockjob.h/

On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote:
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   blockjob.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/blockjob.c b/blockjob.c
> index fbd6c7d873..4982f6a2b5 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -61,6 +61,7 @@ static bool is_block_job(Job *job)
>   
>   BlockJob *block_job_next(BlockJob *bjob)
>   {
> +    assert(qemu_in_main_thread());
>       Job *job = bjob ? &bjob->job : NULL;

Here and...

>       do {
> @@ -72,6 +73,7 @@ BlockJob *block_job_next(BlockJob *bjob)
>   
>   BlockJob *block_job_get(const char *id)
>   {
> +    assert(qemu_in_main_thread());
>       Job *job = job_get(id);

...here, the assertion and declaration should be switched.

Hanna