[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/10] vhost-user-blk: reconnect on any error during realize
|
From: |
Raphael Norwitz |
|
Subject: |
Re: [PATCH 01/10] vhost-user-blk: reconnect on any error during realize |
|
Date: |
Mon, 29 Nov 2021 22:15:12 +0000 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
> >
> > I see. I hadn't looked at the rest of the series yet because I ran out
> > of time, but now that I'm skimming them, I see quite a few places that
> > use non-EPROTO, but I wonder which of them actually should be
> > reconnected. So far all I saw were presumably persistent errors where a
> > retry won't help. Can you give me some examples?
>
> E.g. the particular case you mention earlier, -ECONNREFUSED, is not
> unlikely to happen due to the vhost-user server restart for maintenance;
> in this case retying looks like a reasonable thing to do, doesn't it?
>
Seems like a net-positive to me, expecially with the cleanups in the
rest of the series, but I don't feel strongly.
> Thanks,
> Roman.
>
Re: [PATCH 01/10] vhost-user-blk: reconnect on any error during realize, Raphael Norwitz, 2021/11/29
[PATCH 03/10] chardev/char-socket: tcp_chr_sync_read: don't clobber errno, Roman Kagan, 2021/11/11
[PATCH 02/10] chardev/char-socket: tcp_chr_recv: don't clobber errno, Roman Kagan, 2021/11/11
[PATCH 05/10] vhost-backend: avoid overflow on memslots_limit, Roman Kagan, 2021/11/11