[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 3/7] nbd/client-connection: improve error message of cancelled
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v4 3/7] nbd/client-connection: improve error message of cancelled attempt |
Date: |
Mon, 13 Dec 2021 16:32:36 +0100 |
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
nbd/client-connection.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/nbd/client-connection.c b/nbd/client-connection.c
index 722998c985..2bda42641d 100644
--- a/nbd/client-connection.c
+++ b/nbd/client-connection.c
@@ -351,8 +351,15 @@ nbd_co_establish_connection(NBDClientConnection *conn,
NBDExportInfo *info,
if (conn->err) {
error_propagate(errp, error_copy(conn->err));
} else {
- error_setg(errp,
- "Connection attempt cancelled by other operation");
+ /*
+ * The only possible case here is cancelling by open_timer
+ * during nbd_open(). So, the error message is for that case.
+ * If we have more use cases, we can refactor
+ * nbd_co_establish_connection_cancel() to take an additional
+ * parameter cancel_reason, that would be passed than to the
+ * caller of cancelled nbd_co_establish_connection().
+ */
+ error_setg(errp, "Connection attempt cancelled by timeout");
}
return NULL;
--
2.31.1
- [PATCH v4 0/7] nbd reconnect on open, Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 4/7] iotests.py: add qemu_tool_popen(), Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 1/7] nbd: allow reconnect on open, with corresponding new options, Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 5/7] For qemu_io* functions support --image-opts argument, which conflicts with -f argument from qemu_io_args., Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 2/7] nbd/client-connection: nbd_co_establish_connection(): return real error, Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 6/7] Add qemu-io Popen constructor wrapper. To be used in the following new test commit., Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 3/7] nbd/client-connection: improve error message of cancelled attempt,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v4 7/7] iotests: add nbd-reconnect-on-open test, Vladimir Sementsov-Ogievskiy, 2021/12/13
- Re: [PATCH v4 0/7] nbd reconnect on open, Vladimir Sementsov-Ogievskiy, 2021/12/21