Re: [PATCH v2 07/25] python/qmp: switch qemu-ga-client to AQMP

[Vladimir Sementsov-Ogievskiy]

15.12.2021 22:39, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>

Not simple to check, how much new behavior is equal to the old one.. And 
impossible to check, is everything updated that should be )


> ---
>   python/qemu/qmp/qemu_ga_client.py | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/python/qemu/qmp/qemu_ga_client.py 
> b/python/qemu/qmp/qemu_ga_client.py
> index b3e1d98c9e..15ed430c61 100644
> --- a/python/qemu/qmp/qemu_ga_client.py
> +++ b/python/qemu/qmp/qemu_ga_client.py

[..]

>   
>       try:
>           client = QemuGuestAgentClient(address)
> -    except OSError as err:
> +    except ConnectError as err:
>           print(err)
> -        if err.errno == errno.ECONNREFUSED:
> -            print('Hint: qemu is not running?')
> +        if isinstance(err.exc, ConnectionError):
> +            print('(Is QEMU running?)')

It at least a bit changed from checking errno to checking the class, I'd note 
it in commit message. And anyway commit message may be more informative. Still, 
I just don't care too much about testing framework.

Nothing seems wrong to me, so weak:
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir