qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 18/19] iotests.py: implement unsupported_imgopts


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v4 18/19] iotests.py: implement unsupported_imgopts
Date: Thu, 23 Dec 2021 17:44:46 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

23.12.2021 15:41, Hanna Reitz wrote:
On 03.12.21 14:07, Vladimir Sementsov-Ogievskiy wrote:
We have added support for some addition IMGOPTS in python iotests like
in bash iotests. Similarly to bash iotests, we want a way to skip some
tests which can't work with specific IMGOPTS.

Globally for python iotests we now don't support things like
'data_file=$TEST_IMG.ext_data_file' in IMGOPTS, so, forbid this
globally in iotests.py.

Suggested-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
  tests/qemu-iotests/iotests.py | 15 ++++++++++++++-
  1 file changed, 14 insertions(+), 1 deletion(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>

Can we move this and the next patch before patch 2, though? Otherwise, the 
tests adjusted in the next patch will be broken after patch 2 (when given those 
unsupported options).  The move seems trivial, just wondering whether you know 
of anything that would prohibit this.


OK

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]