[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 16/31] python: move qmp-shell under the AQMP package
From: |
Beraldo Leal |
Subject: |
Re: [PATCH v3 16/31] python: move qmp-shell under the AQMP package |
Date: |
Wed, 12 Jan 2022 10:46:48 -0300 |
On Mon, Jan 10, 2022 at 06:28:55PM -0500, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Beraldo Leal <bleal@redhat.com>
> ---
> python/README.rst | 2 +-
> python/qemu/{qmp => aqmp}/qmp_shell.py | 0
> python/setup.cfg | 2 +-
> scripts/qmp/qmp-shell | 2 +-
> 4 files changed, 3 insertions(+), 3 deletions(-)
> rename python/qemu/{qmp => aqmp}/qmp_shell.py (100%)
>
> diff --git a/python/README.rst b/python/README.rst
> index 9c1fceaee7..fcf74f69ea 100644
> --- a/python/README.rst
> +++ b/python/README.rst
> @@ -59,7 +59,7 @@ Package installation also normally provides executable
> console scripts,
> so that tools like ``qmp-shell`` are always available via $PATH. To
> invoke them without installation, you can invoke e.g.:
>
> -``> PYTHONPATH=~/src/qemu/python python3 -m qemu.qmp.qmp_shell``
> +``> PYTHONPATH=~/src/qemu/python python3 -m qemu.aqmp.qmp_shell``
>
> The mappings between console script name and python module path can be
> found in ``setup.cfg``.
> diff --git a/python/qemu/qmp/qmp_shell.py b/python/qemu/aqmp/qmp_shell.py
> similarity index 100%
> rename from python/qemu/qmp/qmp_shell.py
> rename to python/qemu/aqmp/qmp_shell.py
> diff --git a/python/setup.cfg b/python/setup.cfg
> index 78421411d2..168a79c867 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -67,7 +67,7 @@ console_scripts =
> qom-tree = qemu.utils.qom:QOMTree.entry_point
> qom-fuse = qemu.utils.qom_fuse:QOMFuse.entry_point [fuse]
> qemu-ga-client = qemu.utils.qemu_ga_client:main
> - qmp-shell = qemu.qmp.qmp_shell:main
> + qmp-shell = qemu.aqmp.qmp_shell:main
> aqmp-tui = qemu.aqmp.aqmp_tui:main [tui]
>
> [flake8]
> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> index 4a20f97db7..31b19d73e2 100755
> --- a/scripts/qmp/qmp-shell
> +++ b/scripts/qmp/qmp-shell
> @@ -4,7 +4,7 @@ import os
> import sys
>
> sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..',
> 'python'))
> -from qemu.qmp import qmp_shell
> +from qemu.aqmp import qmp_shell
>
>
> if __name__ == '__main__':
> --
> 2.31.1
Reviewed-by: Beraldo Leal <bleal@redhat.com>
--
Beraldo
- [PATCH v3 07/31] python/aqmp: handle asyncio.TimeoutError on execute(), (continued)
- [PATCH v3 07/31] python/aqmp: handle asyncio.TimeoutError on execute(), John Snow, 2022/01/10
- [PATCH v3 06/31] python/aqmp: add __del__ method to legacy interface, John Snow, 2022/01/10
- [PATCH v3 09/31] python/aqmp: add SocketAddrT to package root, John Snow, 2022/01/10
- [PATCH v3 08/31] python/aqmp: copy type definitions from qmp, John Snow, 2022/01/10
- [PATCH v3 11/31] python/qemu-ga-client: don't use deprecated CLI syntax in usage comment, John Snow, 2022/01/10
- [PATCH v3 12/31] python/qmp: switch qemu-ga-client to AQMP, John Snow, 2022/01/10
- [PATCH v3 10/31] python/aqmp: rename AQMPError to QMPError, John Snow, 2022/01/10
- [PATCH v3 16/31] python: move qmp-shell under the AQMP package, John Snow, 2022/01/10
- Re: [PATCH v3 16/31] python: move qmp-shell under the AQMP package,
Beraldo Leal <=
- [PATCH v3 14/31] python/qmp: switch qmp-shell to AQMP, John Snow, 2022/01/10
- [PATCH v3 15/31] python: move qmp utilities to python/qemu/utils, John Snow, 2022/01/10
- [PATCH v3 17/31] python/machine: permanently switch to AQMP, John Snow, 2022/01/10
- [PATCH v3 13/31] python/qmp: switch qom tools to AQMP, John Snow, 2022/01/10
- [PATCH v3 19/31] scripts/cpu-x86-uarch-abi: switch to AQMP, John Snow, 2022/01/10
- [PATCH v3 18/31] scripts/cpu-x86-uarch-abi: fix CLI parsing, John Snow, 2022/01/10
- [PATCH v3 20/31] scripts/render-block-graph: switch to AQMP, John Snow, 2022/01/10