Re: [PATCH v3 31/31] python: rename 'aqmp-tui' to 'qmp-tui'

[Beraldo Leal]

On Mon, Jan 10, 2022 at 06:29:10PM -0500, John Snow wrote:
> This is the last vestige of the "aqmp" moniker surviving in the tree; remove 
> it.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/qmp/{aqmp_tui.py => qmp_tui.py} | 12 ++++++------
>  python/setup.cfg                            |  6 +++---
>  2 files changed, 9 insertions(+), 9 deletions(-)
>  rename python/qemu/qmp/{aqmp_tui.py => qmp_tui.py} (98%)
> 
> diff --git a/python/qemu/qmp/aqmp_tui.py b/python/qemu/qmp/qmp_tui.py
> similarity index 98%
> rename from python/qemu/qmp/aqmp_tui.py
> rename to python/qemu/qmp/qmp_tui.py
> index 184a3e4690..17dc94e7c3 100644
> --- a/python/qemu/qmp/aqmp_tui.py
> +++ b/python/qemu/qmp/qmp_tui.py
> @@ -6,13 +6,13 @@
>  # This work is licensed under the terms of the GNU GPL, version 2 or
>  # later.  See the COPYING file in the top-level directory.
>  """
> -AQMP TUI
> +QMP TUI
>  
> -AQMP TUI is an asynchronous interface built on top the of the AQMP library.
> +QMP TUI is an asynchronous interface built on top the of the QMP library.
>  It is the successor of QMP-shell and is bought-in as a replacement for it.
>  
> -Example Usage: aqmp-tui <SOCKET | TCP IP:PORT>
> -Full Usage: aqmp-tui --help
> +Example Usage: qmp-tui <SOCKET | TCP IP:PORT>
> +Full Usage: qmp-tui --help
>  """
>  
>  import argparse
> @@ -129,7 +129,7 @@ def has_handler_type(logger: logging.Logger,
>  
>  class App(QMPClient):
>      """
> -    Implements the AQMP TUI.
> +    Implements the QMP TUI.
>  
>      Initializes the widgets and starts the urwid event loop.
>  
> @@ -612,7 +612,7 @@ def main() -> None:
>      Driver of the whole script, parses arguments, initialize the TUI and
>      the logger.
>      """
> -    parser = argparse.ArgumentParser(description='AQMP TUI')
> +    parser = argparse.ArgumentParser(description='QMP TUI')
>      parser.add_argument('qmp_server', help='Address of the QMP server. '
>                          'Format <UNIX socket path | TCP addr:port>')
>      parser.add_argument('--num-retries', type=int, default=10,
> diff --git a/python/setup.cfg b/python/setup.cfg
> index 911ae02de7..4614521dea 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -51,7 +51,7 @@ devel =
>  fuse =
>      fusepy >= 2.0.4
>  
> -# AQMP TUI dependencies
> +# QMP TUI dependencies
>  tui =
>      urwid >= 2.1.2
>      urwid-readline >= 0.13
> @@ -67,7 +67,7 @@ console_scripts =
>      qom-fuse = qemu.utils.qom_fuse:QOMFuse.entry_point [fuse]
>      qemu-ga-client = qemu.utils.qemu_ga_client:main
>      qmp-shell = qemu.qmp.qmp_shell:main
> -    aqmp-tui = qemu.qmp.aqmp_tui:main [tui]
> +    qmp-tui = qemu.qmp.qmp_tui:main [tui]
>  
>  [flake8]
>  extend-ignore = E722  # Prefer pylint's bare-except checks to flake8's
> @@ -83,7 +83,7 @@ namespace_packages = True
>  # fusepy has no type stubs:
>  allow_subclassing_any = True
>  
> -[mypy-qemu.qmp.aqmp_tui]
> +[mypy-qemu.qmp.qmp_tui]
>  # urwid and urwid_readline have no type stubs:
>  allow_subclassing_any = True
>  
> -- 
> 2.31.1
>

Reviewed-by: Beraldo Leal <bleal@redhat.com>

--
Beraldo