Re: [PATCH 00/12] Removal of Aiocontext lock through drains: protect bdr

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/12] Removal of Aiocontext lock through drains: protect bdr

From:	Paolo Bonzini
Subject:	Re: [PATCH 00/12] Removal of Aiocontext lock through drains: protect bdrv_replace_child_noperm.
Date:	Wed, 19 Jan 2022 10:51:23 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0

On 1/18/22 17:27, Emanuele Giuseppe Esposito wrote:

* Finally fully enable assert_bdrv_graph_writable(), checking also for the
   drains, in patch 11.

Wow, this is definitely not just moving code around! It's great thatyou could pull this off. It gives me a lot more confidence that thelocking model and the graph/IO split are correct, and also a lot moreconfidence about the logic to move the drains back and forth.

It does add a lot more complication to the API with all the _unlockedvariants, but I think we're getting closer and closer to the endgame forthe AioContext lock.


Paolo

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 12/12] block.c: additional assert qemu in main tread, (continued)
- [PATCH 12/12] block.c: additional assert qemu in main tread, Emanuele Giuseppe Esposito, 2022/01/18
- [PATCH 06/12] test-bdrv-drain.c: remove test_detach_by_parent_cb(), Emanuele Giuseppe Esposito, 2022/01/18
- [PATCH 03/12] block.c: bdrv_replace_child_noperm: first remove the child, and then call ->detach(), Emanuele Giuseppe Esposito, 2022/01/18
- [PATCH 02/12] block/io.c: make bdrv_do_drained_begin_quiesce static and introduce bdrv_drained_begin_no_poll, Emanuele Giuseppe Esposito, 2022/01/18
  - Re: [PATCH 02/12] block/io.c: make bdrv_do_drained_begin_quiesce static and introduce bdrv_drained_begin_no_poll, Paolo Bonzini, 2022/01/19
- [PATCH 04/12] block.c: bdrv_replace_child_noperm: first call ->attach(), and then add child, Emanuele Giuseppe Esposito, 2022/01/18
- [PATCH 07/12] block/io.c: introduce bdrv_subtree_drained_{begin/end}_unlocked, Emanuele Giuseppe Esposito, 2022/01/18
  - Re: [PATCH 07/12] block/io.c: introduce bdrv_subtree_drained_{begin/end}_unlocked, Paolo Bonzini, 2022/01/19
  - Re: [PATCH 07/12] block/io.c: introduce bdrv_subtree_drained_{begin/end}_unlocked, Stefan Hajnoczi, 2022/01/26
- [PATCH 11/12] block/io.c: fully enable assert_bdrv_graph_writable, Emanuele Giuseppe Esposito, 2022/01/18
- Re: [PATCH 00/12] Removal of Aiocontext lock through drains: protect bdrv_replace_child_noperm., Paolo Bonzini <=
- Re: [PATCH 00/12] Removal of Aiocontext lock through drains: protect bdrv_replace_child_noperm., Stefan Hajnoczi, 2022/01/26
  - Re: [PATCH 00/12] Removal of Aiocontext lock through drains: protect bdrv_replace_child_noperm., Paolo Bonzini, 2022/01/27
    - Re: [PATCH 00/12] Removal of Aiocontext lock through drains: protect bdrv_replace_child_noperm., Emanuele Giuseppe Esposito, 2022/01/28

Prev by Date: Re: [PATCH 10/12] block.c: add subtree_drains where needed
Next by Date: Re: [PATCH 07/12] block/io.c: introduce bdrv_subtree_drained_{begin/end}_unlocked
Previous by thread: [PATCH 11/12] block/io.c: fully enable assert_bdrv_graph_writable
Next by thread: Re: [PATCH 00/12] Removal of Aiocontext lock through drains: protect bdrv_replace_child_noperm.
Index(es):
- Date
- Thread