qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 15/16] job.c: enable job lock/unlock and remove Aiocontext


From: Paolo Bonzini
Subject: Re: [PATCH v3 15/16] job.c: enable job lock/unlock and remove Aiocontext locks
Date: Wed, 19 Jan 2022 11:35:03 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0

On 1/5/22 15:02, Emanuele Giuseppe Esposito wrote:

Now that they are not nop anymore, remove the aiocontext
to avoid deadlocks.

Ok, that should have been in patch 1, together with a description of the deadlocks. :) Disregard that review.

There is only one JobDriver callback, ->free() that assumes that
the aiocontext lock is held (because it calls bdrv_unref), so for
now keep that under aiocontext lock.

This explains the issue with detach_child in the other series, too.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]