|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v5 28/31] block.c: assert BQL lock held in bdrv_co_invalidate_cache |
Date: | Thu, 20 Jan 2022 14:22:50 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 1/19/22 19:34, Kevin Wolf wrote:
So if we go back to a bdrv_invalidate_cache() that does all the graph manipulations (and asserts that we're in the main loop) and then have a much smaller bdrv_co_invalidate_cache() that basically just calls into the driver, would that solve the problem?
I was going to suggest something similar, and even name the former bdrv_activate(). Then bdrv_activate() is a graph manipulation function, while bdrv_co_invalidate_cache() is an I/O function.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |