[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.0 1/4] hw/nvme: add struct for zone management send
From: |
Keith Busch |
Subject: |
Re: [PATCH for-7.0 1/4] hw/nvme: add struct for zone management send |
Date: |
Wed, 26 Jan 2022 09:00:10 -0800 |
On Thu, Nov 25, 2021 at 08:37:32AM +0100, Klaus Jensen wrote:
> +typedef struct QEMU_PACKED NvmeZoneSendCmd {
> + uint8_t opcode;
> + uint8_t flags;
> + uint16_t cid;
> + uint32_t nsid;
> + uint32_t rsvd2[4];
> + NvmeCmdDptr dptr;
> + uint64_t slba;
> + uint32_t rsvd12;
> + uint8_t zsa;
> + uint8_t zsflags[3];
This should be just a single uint8_t for zsflags, followed by
'uint8_t rsvd[2]'.
Otherwise, looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH for-7.0 1/4] hw/nvme: add struct for zone management send,
Keith Busch <=