Re: [PULL 00/38] Migration 20220127 patches

[Juan Quintela]

Peter Maydell <peter.maydell@linaro.org> wrote:
> On Thu, 27 Jan 2022 at 15:06, Juan Quintela <quintela@redhat.com> wrote:
>>
>> The following changes since commit 48302d4eb628ff0bea4d7e92cbf6b726410eb4c3:
>>
>>   Merge remote-tracking branch
>> 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20220126' into staging
>> (2022-01-26 10:59:50 +0000)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.com/juan.quintela/qemu.git 
>> tags/migration-20220127-pull-request
>>
>> for you to fetch changes up to 4e29a822de430e8d0d8bf5c61aaff0561a713d84:
>>
>>   migration: Move temp page setup and cleanup into separate functions 
>> (2022-01-27 13:37:55 +0100)
>>
>> ----------------------------------------------------------------
>> Migration Pull request
>>
>> Hi
>>
>> This pull request includes every patch ack'd on the list for migration.  In 
>> no particular order:
>>
>> - ram_transferred_add() - (Edmondson)
>> - vmstate canary (dgilbert)
>> - minimum_version_id_old removal (peter maydell)
>> - postcopy cleanups (peter xu)
>> - more cleanups (Philippe)
>> - yet more cleanups (zheng)
>> - colo and cleanups (zhang)
>
> Hi; this fails because we hit this assert in the vmstate canary check
> on some of the CI jobs, for instance:
> https://gitlab.com/qemu-project/qemu/-/jobs/2024872142
> and also on the NetBSD VM in tests/vm.

I dropped them on my PULL request, but there is something fishy on
aarch64 for migration.  It makes exactly zero sense to fail with this
patch.  Or something is missing a VMSTATE_END that only happens on
aarch64.

I will take a look.

Later, Juan.

PD.  As Dave said, the patch makes sense to drop because we need a new
libslirp before pushing for it.