On Sun, Jan 30, 2022 at 07:50:41PM +0100, Philippe Mathieu-Daudé wrote:
On 28/1/22 21:54, Eric Blake wrote:
On Wed, Jan 19, 2022 at 01:14:39PM +0100, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daude <f4bug@amsat.org>
'git am' used this line to insert the authorship...
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
...then left this line in the commit body, which I manually deleted,
without spotting the difference between the two.
The doubled From: looks odd here. I'll double-check that git doesn't
mess up the actual commit once I apply the patch.
I played with the git --from option to not appear in the list as
'"Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>':
https://lore.kernel.org/qemu-devel/efc5f304-f3d2-ff7b-99a6-673595ff0259@amsat.org/
by using a different sendemail.from (removing the acute in my
lastname) to force a correct author.from.
git-am should have picked the 2nd form, but I see the 1st in commit
3a8fa0edd1. Just curious, did you had to modify it manually?
Alas, since I managed to overlook the change in the acute (I suppose
I'm cursed with having a boring name, so unlike many list participants
who are overjoyed by the power of UTF-8 to make self-expression more
accurate, I have not had as much experience with thinking about it),
my manual edits explain why the merged commit ended up with a less
desirable spelling. I apologize for the mishap. Do we need/want a
.mailmap entry to aid git at listing your preferred spelling?