Re: [PATCH 1/5] linux-headers: Add vduse.h

[Yongji Xie]

On Mon, Feb 7, 2022 at 9:12 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Tue, Jan 25, 2022 at 09:17:56PM +0800, Xie Yongji wrote:
> > diff --git a/scripts/update-linux-headers.sh 
> > b/scripts/update-linux-headers.sh
> > index fea4d6eb65..4c7846076f 100755
> > --- a/scripts/update-linux-headers.sh
> > +++ b/scripts/update-linux-headers.sh
> > @@ -198,6 +198,7 @@ for i in "$tmpdir"/include/linux/*virtio*.h \
> >           "$tmpdir/include/linux/const.h" \
> >           "$tmpdir/include/linux/kernel.h" \
> >           "$tmpdir/include/linux/vhost_types.h" \
> > +         "$tmpdir/include/linux/vduse.h" \
> >           "$tmpdir/include/linux/sysinfo.h"; do
> >      cp_portable "$i" "$output/include/standard-headers/linux"
>
> VDUSE is only available on Linux hosts so it should go in linux-headers/
> instead of standard-headers/linux/:
>
>   # - linux-headers/ for files that are required for compiling for a
>   #   Linux host.  Generally we have these so we can use kernel structs
>   #   and defines that are more recent than the headers that might be
>   #   installed on the host system.  Usually this script can do simple
>   #   file copies for these headers.
>   #
>   # - include/standard-headers/ for files that are used for guest
>   #   device emulation and are required on all hosts.  For instance, we
>   #   get our definitions of the virtio structures from the Linux
>   #   kernel headers, but we need those definitions regardless of which
>   #   host OS we are building for.  This script has to be careful to
>   #   sanitize the headers to remove any use of Linux-specifics such as
>   #   types like "__u64".  This work is done in the cp_portable function.

Got it! Will fix it in v2.

Thanks,
Yongji