qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

downstream extensions


From: Vladimir Sementsov-Ogievskiy
Subject: downstream extensions
Date: Wed, 9 Feb 2022 15:33:04 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

Hi all!

We declare a kind of __com.redhat_drive-mirror syntax for downstream extensions 
of QAPI.

That's inconvenient:

Assume I want to merge now my keep-dirty option for Qcow2 driver "[PATCH v2 0/2] 
qcow2: add keep-dirty open option" to our downstream. To avoid possible conflicts 
with upstream in future, I should now call it __com.virtuozzo_keep-dirty. Not saying 
about this being too awkward, there is a real problem:

I want to support dot-object-notation syntax, i.e. something like

qemu-img check --image-opts driver=qcow2,keep-dirty=true,file.filename=img.qcow2

And this way, a period inside a name looks ambiguous, as it looks like subproperty of 
"__com" property.

I now tested, it still works somehow, and test from my series passes with

 
keep_dirty_opts="driver=qcow2,__com.virtuozzo_keep-dirty=true,file.filename=$TEST_IMG"

But anyway, it looks ambiguous, and I don't want to use it and share with my 
colleagues.

In past, I used x-vz- prefix for downstream names (before I heard about 
__RFQDN_ notation declared in QAPI spec), that was more convenient. But still, 
that is not correct..

I now think to use just __vz_ prefix. Such name will never appear upstream, and 
unlikely to be used by Rhel downstream which is our base. And I don't care 
about any other downstreams.


Any thoughts? Should we change the recommendations somehow? I think allowing 
dots in names in the object model is a bad idea.

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]