[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test in
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations |
Date: |
Fri, 11 Feb 2022 10:29:17 +0100 |
Am 09.02.2022 um 11:15 hat Thomas Huth geschrieben:
> If multiple tests run in parallel, they must use unique file
> names for the test output.
>
> Suggested-by: Hanna Reitz <hreitz@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/testrunner.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/testrunner.py
> b/tests/qemu-iotests/testrunner.py
> index 0eace147b8..9d20f51bb1 100644
> --- a/tests/qemu-iotests/testrunner.py
> +++ b/tests/qemu-iotests/testrunner.py
> @@ -259,7 +259,7 @@ def do_run_test(self, test: str, mp: bool) -> TestResult:
> """
>
> f_test = Path(test)
> - f_bad = Path(f_test.name + '.out.bad')
> + f_bad = Path(f'{os.getpid()}-{f_test.name}.out.bad')
> f_notrun = Path(f_test.name + '.notrun')
> f_casenotrun = Path(f_test.name + '.casenotrun')
> f_reference = Path(self.find_reference(test))
Hmm... It does make sense, but nobody ever cleans those files up.
Currently, the next run of the test will just overwrite the existing
file or delete it when the test succeeds. So after running the test
suite, you have .out.bad files for every failed test, but not for those
that succeeded.
After this change, won't the test directory accumulate tons of .out.bad
files over time?
Kevin
- [PATCH v2 0/8] Improve integration of iotests in the meson test harness, Thomas Huth, 2022/02/09
- [PATCH v2 2/8] tests/qemu-iotests: Improve the check for GNU sed, Thomas Huth, 2022/02/09
- [PATCH v2 3/8] tests/qemu-iotests/meson.build: Improve the indentation, Thomas Huth, 2022/02/09
- [PATCH v2 6/8] tests: Do not treat the iotests as separate meson test target anymore, Thomas Huth, 2022/02/09
- [PATCH v2 8/8] tests: Remove check-block.sh, Thomas Huth, 2022/02/09
- [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations, Thomas Huth, 2022/02/09
- Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations,
Kevin Wolf <=
- Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations, Vladimir Sementsov-Ogievskiy, 2022/02/11
- Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations, Thomas Huth, 2022/02/11
- Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations, Kevin Wolf, 2022/02/11
- Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations, Hanna Reitz, 2022/02/11
- Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations, Kevin Wolf, 2022/02/11
[PATCH v2 4/8] tests/qemu-iotests: Allow to run "./check -n" from the source directory, too, Thomas Huth, 2022/02/09
[PATCH v2 7/8] tests/qemu-iotests/testrunner: Print diff to stderr in TAP mode, Thomas Huth, 2022/02/09
[PATCH v2 5/8] tests/qemu-iotests/meson.build: Call the 'check' script directly, Thomas Huth, 2022/02/09