[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 15/15] hw/nvme: Update the initalization place for the AER
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v5 15/15] hw/nvme: Update the initalization place for the AER queue |
Date: |
Fri, 18 Feb 2022 07:49:33 +0100 |
On Feb 17 18:45, Lukasz Maniak wrote:
> From: Łukasz Gieryk <lukasz.gieryk@linux.intel.com>
>
> This patch updates the initialization place for the AER queue, so it’s
> initialized once, at controller initialization, and not every time
> controller is enabled.
>
> While the original version works for a non-SR-IOV device, as it’s hard
> to interact with the controller if it’s not enabled, the multiple
> reinitialization is not necessarily correct.
>
> With the SR/IOV feature enabled a segfault can happen: a VF can have its
> controller disabled, while a namespace can still be attached to the
> controller through the parent PF. An event generated in such case ends
> up on an uninitialized queue.
>
> While it’s an interesting question whether a VF should support AER in
> the first place, I don’t think it must be answered today.
>
> Signed-off-by: Łukasz Gieryk <lukasz.gieryk@linux.intel.com>
Looks good.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
signature.asc
Description: PGP signature
- [PATCH v5 05/15] hw/nvme: Add support for SR-IOV, (continued)
- [PATCH v5 05/15] hw/nvme: Add support for SR-IOV, Lukasz Maniak, 2022/02/17
- [PATCH v5 10/15] hw/nvme: Remove reg_size variable and update BAR0 size calculation, Lukasz Maniak, 2022/02/17
- [PATCH v5 08/15] hw/nvme: Implement the Function Level Reset, Lukasz Maniak, 2022/02/17
- [PATCH v5 09/15] hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime, Lukasz Maniak, 2022/02/17
- [PATCH v5 11/15] hw/nvme: Calculate BAR attributes in a function, Lukasz Maniak, 2022/02/17
- [PATCH v5 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers, Lukasz Maniak, 2022/02/17
- [PATCH v5 13/15] hw/nvme: Add support for the Virtualization Management command, Lukasz Maniak, 2022/02/17
- [PATCH v5 15/15] hw/nvme: Update the initalization place for the AER queue, Lukasz Maniak, 2022/02/17
- Re: [PATCH v5 15/15] hw/nvme: Update the initalization place for the AER queue,
Klaus Jensen <=
- [PATCH v5 14/15] docs: Add documentation for SR-IOV and Virtualization Enhancements, Lukasz Maniak, 2022/02/17
- Re: [PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements, Michael S. Tsirkin, 2022/02/18
- Re: [PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements, Michael S. Tsirkin, 2022/02/18