[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 11/18] iotests: change supports_quorum to use qemu_img
From: |
John Snow |
Subject: |
[PATCH v2 11/18] iotests: change supports_quorum to use qemu_img |
Date: |
Mon, 21 Feb 2022 17:34:06 -0500 |
Similar to other recent changes: use the qemu_img invocation that
supports throwing loud, nasty exceptions when it fails for surprising
reasons.
(Why would "--help" ever fail? I don't know, but consistency is like a
well-manicured bonsai.)
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/qemu-iotests/iotests.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index cbb3af71523..882d3e0214a 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -1428,8 +1428,8 @@ def _verify_imgopts(unsupported: Sequence[str] = ()) ->
None:
notrun(f'not suitable for this imgopts: {imgopts}')
-def supports_quorum():
- return 'quorum' in qemu_img_pipe('--help')
+def supports_quorum() -> bool:
+ return 'quorum' in qemu_img('--help').stdout
def verify_quorum():
'''Skip test suite if quorum support is not available'''
--
2.34.1
- [PATCH v2 02/18] iotests: add VerboseProcessError, (continued)
- [PATCH v2 02/18] iotests: add VerboseProcessError, John Snow, 2022/02/21
- [PATCH v2 01/18] python/utils: add enboxify() text decoration utility, John Snow, 2022/02/21
- [PATCH v2 03/18] iotests: Remove explicit checks for qemu_img() == 0, John Snow, 2022/02/21
- [PATCH v2 05/18] iotests: fortify compare_images() against crashes, John Snow, 2022/02/21
- [PATCH v2 06/18] iotests: add qemu_img_json(), John Snow, 2022/02/21
- [PATCH v2 04/18] iotests: make qemu_img raise on non-zero rc by default, John Snow, 2022/02/21
- [PATCH v2 07/18] iotests: use qemu_img_json() when applicable, John Snow, 2022/02/21
- [PATCH v2 08/18] iotests: add qemu_img_info(), John Snow, 2022/02/21
- [PATCH v2 09/18] iotests: remove-bitmap-from-backing: use qemu_img_info(), John Snow, 2022/02/21
- [PATCH v2 10/18] iotests: add qemu_img_map() function, John Snow, 2022/02/21
- [PATCH v2 11/18] iotests: change supports_quorum to use qemu_img,
John Snow <=
- [PATCH v2 12/18] iotests: replace unchecked calls to qemu_img_pipe(), John Snow, 2022/02/21
- [PATCH v2 13/18] iotests: remove external calls to qemu_img_pipe(), John Snow, 2022/02/21
- [PATCH v2 14/18] iotests: move has_working_luks onto qemu_img(), John Snow, 2022/02/21
- [PATCH v2 15/18] iotests: remove qemu_img_log('create', ...) calls, John Snow, 2022/02/21
- [PATCH v2 16/18] iotests: remove qemu_img_pipe(), John Snow, 2022/02/21
- [PATCH v2 18/18] iotests: reimplement img_info_log in terms of qemu_img_log, John Snow, 2022/02/21
- [PATCH v2 17/18] iotests: make qemu_img_log() check log level, John Snow, 2022/02/21