qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/qemu-iotests/testrunner: Quote "case not run" lines in


From: Hanna Reitz
Subject: Re: [PATCH] tests/qemu-iotests/testrunner: Quote "case not run" lines in TAP mode
Date: Thu, 24 Feb 2022 17:56:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 23.02.22 13:43, Thomas Huth wrote:
In TAP mode, the stdout is reserved for the TAP protocol, so we
have to make sure to mark other lines with a comment '#' character
at the beginning to avoid that the TAP parser at the other end
gets confused.

To test this condition, run "configure" for example with:

  
--block-drv-rw-whitelist=copy-before-write,qcow2,raw,file,host_device,blkdebug,null-co,copy-on-read

so that iotest 041 will report that some tests are not run due to
the missing "quorum" driver. Without this change, "make check-block"
fails since the meson tap parser gets confused by these messages.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  tests/qemu-iotests/testrunner.py | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

Thanks, applied to my block branch:

https://gitlab.com/hreitz/qemu/-/commits/block

Hanna




reply via email to

[Prev in Thread] Current Thread [Next in Thread]