[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 11/18] iotests: change supports_quorum to use qemu_img
From: |
John Snow |
Subject: |
[PATCH v4 11/18] iotests: change supports_quorum to use qemu_img |
Date: |
Thu, 17 Mar 2022 19:49:30 -0400 |
Similar to other recent changes: use the qemu_img() invocation that
supports throwing loud, nasty exceptions when it fails for surprising
reasons.
(Why would "--help" ever fail? I don't know, but eliminating *all* calls
to qemu-img that do not go through qemu_img() is my goal, so
qemu_img_pipe() has to be removed.)
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
---
tests/qemu-iotests/iotests.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 58fb1734b5..17065fc176 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -1427,8 +1427,8 @@ def _verify_imgopts(unsupported: Sequence[str] = ()) ->
None:
notrun(f'not suitable for this imgopts: {imgopts}')
-def supports_quorum():
- return 'quorum' in qemu_img_pipe('--help')
+def supports_quorum() -> bool:
+ return 'quorum' in qemu_img('--help').stdout
def verify_quorum():
'''Skip test suite if quorum support is not available'''
--
2.34.1
- [PATCH v4 00/18] iotests: add enhanced debugging info to qemu-img failures, John Snow, 2022/03/17
- [PATCH v4 01/18] python/utils: add add_visual_margin() text decoration utility, John Snow, 2022/03/17
- [PATCH v4 06/18] iotests: add qemu_img_json(), John Snow, 2022/03/17
- [PATCH v4 02/18] python/utils: add VerboseProcessError, John Snow, 2022/03/17
- [PATCH v4 03/18] iotests: Remove explicit checks for qemu_img() == 0, John Snow, 2022/03/17
- [PATCH v4 05/18] iotests: fortify compare_images() against crashes, John Snow, 2022/03/17
- [PATCH v4 11/18] iotests: change supports_quorum to use qemu_img,
John Snow <=
- [PATCH v4 14/18] iotests: remove remaining calls to qemu_img_pipe(), John Snow, 2022/03/17
- [PATCH v4 10/18] iotests: add qemu_img_map() function, John Snow, 2022/03/17
- [PATCH v4 07/18] iotests: use qemu_img_json() when applicable, John Snow, 2022/03/17
- [PATCH v4 15/18] iotests: use qemu_img() in has_working_luks(), John Snow, 2022/03/17
- [PATCH v4 13/18] iotests/149: Remove qemu_img_pipe() call, John Snow, 2022/03/17
- [PATCH v4 12/18] iotests: replace unchecked calls to qemu_img_pipe(), John Snow, 2022/03/17
- [PATCH v4 18/18] iotests: make qemu_img_log and img_info_log raise on error, John Snow, 2022/03/17
- [PATCH v4 17/18] iotests: remove qemu_img_pipe_and_status(), John Snow, 2022/03/17