Re: [PATCH v2 5/7] block/block-copy: block_copy(): add timeout_ns parameter

[Hanna Reitz]

On 01.04.22 15:16, Hanna Reitz wrote:
> On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote:
> > Add possibility to limit block_copy() call in time. To be used in the
> > next commit.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> > ---
> >   block/block-copy.c         | 26 +++++++++++++++++++-------
> >   block/copy-before-write.c  |  2 +-
> >   include/block/block-copy.h |  2 +-
> >   3 files changed, 21 insertions(+), 9 deletions(-)
> >
> > diff --git a/block/block-copy.c b/block/block-copy.c
> > index ec46775ea5..b47cb188dd 100644
> > --- a/block/block-copy.c
> > +++ b/block/block-copy.c
>
> [...]
>
> > @@ -894,12 +902,16 @@ int coroutine_fn block_copy(BlockCopyState *s, 
> > int64_t start, int64_t bytes,
> >           .max_workers = BLOCK_COPY_MAX_WORKERS,
> >       };
> >   -    return block_copy_common(&call_state);
> > -}
> > +    ret = qemu_co_timeout(block_copy_async_co_entry, call_state, 
> > timeout_ns,
> > +                          g_free);
>
> A direct path for timeout_ns == 0 might still be nice to have.

Ah, never mind, just saw that qemu_co_timeout() itself has a direct path 
for this.  Hadn’t noticed that before.