qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-7.1 0/2] throttle-groups: use QEMU_CLOCK_REALTIME


From: Vladimir Sementsov-Ogievskiy
Subject: [PATCH for-7.1 0/2] throttle-groups: use QEMU_CLOCK_REALTIME
Date: Wed, 6 Apr 2022 18:32:00 +0300

Hi all!

Honestly, I don't know why QEMU_CLOCK_VIRTUAL is used here. Comment say
that that's specially for throttle tests, but the simple test (patch 02)
just hangs because QEMU_CLOCK_VIRTUAL clock just doesn't tick in this
environment.. And if we change the clock to QEMU_CLOCK_REALTIME, new
test works, and old tests work as well.

What the relation between QEMU_CLOCK_VIRTUAL, qtest and throttle?
This code is here since "throttle: Add throttle group support" of 2015..

Vladimir Sementsov-Ogievskiy (2):
  block/throttle-groups: use QEMU_CLOCK_REALTIME for qtest too
  iotests: add throttle test

 block/throttle-groups.c               |  4 ---
 tests/qemu-iotests/tests/throttle     | 50 +++++++++++++++++++++++++++
 tests/qemu-iotests/tests/throttle.out |  0
 3 files changed, 50 insertions(+), 4 deletions(-)
 create mode 100755 tests/qemu-iotests/tests/throttle
 create mode 100644 tests/qemu-iotests/tests/throttle.out

-- 
2.35.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]