[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/3] util/thread-pool: Expose minimun and maximum size
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 0/3] util/thread-pool: Expose minimun and maximum size |
Date: |
Mon, 25 Apr 2022 07:22:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Nicolas Saenz Julienne <nsaenzju@redhat.com> writes:
> As discussed on the previous RFC[1] the thread-pool's dynamic thread
> management doesn't play well with real-time and latency sensitive
> systems. This series introduces a set of controls that'll permit
> achieving more deterministic behaviours, for example by fixing the
> pool's size.
>
> We first introduce a new common interface to event loop configuration by
> moving iothread's already available properties into an abstract class
> called 'EventLooopBackend' and have both 'IOThread' and the newly
> created 'MainLoop' inherit the properties from that class.
>
> With this new configuration interface in place it's relatively simple to
> introduce new options to fix the even loop's thread pool sizes. The
> resulting QAPI looks like this:
>
> -object main-loop,id=main-loop,thread-pool-min=1,thread-pool-max=1
>
> Note that all patches are bisect friendly and pass all the tests.
>
> [1]
> https://patchwork.ozlabs.org/project/qemu-devel/patch/20220202175234.656711-1-nsaenzju@redhat.com/
>
> @Stefan I kept your Signed-off-by, since the changes trivial/not
> thread-pool related
With the doc nit in PATCH 2 addressed, QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>