qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 4/8] async: register/unregister aiocontext in graph lo


From: Emanuele Giuseppe Esposito
Subject: Re: [RFC PATCH v2 4/8] async: register/unregister aiocontext in graph lock list
Date: Fri, 29 Apr 2022 10:37:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0


Am 29/04/2022 um 00:19 schrieb Paolo Bonzini:
> On 4/28/22 15:46, Stefan Hajnoczi wrote:
>>>     if have_block
>>>     util_ss.add(files('aiocb.c', 'async.c', 'aio-wait.c'))
>>> +  util_ss.add(files('../block/graph-lock.c'))
>> Why is it in block/ if it needs to be built into libqemuutil?
> Maybe register_aiocontext, unregister_aiocontext and
> aio_context_list_lock can be placed in util/async.c?
> 

Yes the above functions are added in util/async.c. It's the best way to
automatically add an AioContext when it is created and destroyed.

Not really sure where to put it honestly, it's a block layer graph lock
so it made sense putting it in block/ but it is not reachable from async.

Should I put graph-lock.c in util/? But then won't block/meson.build
need it anyways to use it in block/?

Emanuele




reply via email to

[Prev in Thread] Current Thread [Next in Thread]