[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/10] iotests/testrunner: Flush after run_test()
From: |
Kevin Wolf |
Subject: |
[PULL 03/10] iotests/testrunner: Flush after run_test() |
Date: |
Thu, 12 May 2022 17:33:54 +0200 |
From: Hanna Reitz <hreitz@redhat.com>
When stdout is not a terminal, the buffer may not be flushed at each end
of line, so we should flush after each test is done. This is especially
apparent when run by check-block, in two ways:
First, when running make check-block -jX with X > 1, progress indication
was missing, even though testrunner.py does theoretically print each
test's status once it has been run, even in multi-processing mode.
Flushing after each test restores this progress indication.
Second, sometimes make check-block failed altogether, with an error
message that "too few tests [were] run". I presume that's because one
worker process in the job pool did not get to flush its stdout before
the main process exited, and so meson did not get to see that worker's
test results. In any case, by flushing at the end of run_test(), the
problem has disappeared for me.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220506134215.10086-1-hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/testrunner.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
index aae70a8341..10d9e8ef27 100644
--- a/tests/qemu-iotests/testrunner.py
+++ b/tests/qemu-iotests/testrunner.py
@@ -378,6 +378,7 @@ def run_test(self, test: str,
else:
print(res.casenotrun)
+ sys.stdout.flush()
return res
def run_tests(self, tests: List[str], jobs: int = 1) -> bool:
--
2.35.3
- [PULL 00/10] Block layer patches, Kevin Wolf, 2022/05/12
- [PULL 01/10] coroutine: Rename qemu_coroutine_inc/dec_pool_size(), Kevin Wolf, 2022/05/12
- [PULL 02/10] coroutine: Revert to constant batch size, Kevin Wolf, 2022/05/12
- [PULL 10/10] qemu-iotests: inline common.config into common.rc, Kevin Wolf, 2022/05/12
- [PULL 03/10] iotests/testrunner: Flush after run_test(),
Kevin Wolf <=
- [PULL 07/10] tests/qtest/fdc-test: Add a regression test for CVE-2021-3507, Kevin Wolf, 2022/05/12
- [PULL 06/10] hw/block/fdc: Prevent end-of-track overrun (CVE-2021-3507), Kevin Wolf, 2022/05/12
- [PULL 08/10] qemu-nbd: Pass max connections to blockdev layer, Kevin Wolf, 2022/05/12
- [PULL 09/10] nbd/server: Allow MULTI_CONN for shared writable exports, Kevin Wolf, 2022/05/12
- [PULL 04/10] tests/qemu-iotests: print intent to run a test in TAP mode, Kevin Wolf, 2022/05/12
- [PULL 05/10] .gitlab-ci.d: export meson testlog.txt as an artifact, Kevin Wolf, 2022/05/12
- Re: [PULL 00/10] Block layer patches, Richard Henderson, 2022/05/12