[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] aio_wait_kick: add missing memory barrier
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH] aio_wait_kick: add missing memory barrier |
|
Date: |
Wed, 25 May 2022 15:42:41 +0100 |
On Tue, May 24, 2022 at 01:30:54PM -0400, Emanuele Giuseppe Esposito wrote:
> It seems that aio_wait_kick always required a memory barrier
> or atomic operation in the caller, but nobody actually
> took care of doing it.
>
> Let's put the barrier in the function instead, and pair it
> with another one in AIO_WAIT_WHILE. Read aio_wait_kick()
> comment for further explanation.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> include/block/aio-wait.h | 2 ++
> util/aio-wait.c | 16 +++++++++++++++-
> 2 files changed, 17 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature