Re: [PATCH v3 01/10] block: Add a 'flags' param to bdrv_{pread,pwrite,pwrite_sync}()

[Stefan Hajnoczi]

On Thu, May 19, 2022 at 03:48:31PM +0100, Alberto Faria wrote:
> For consistency with other I/O functions, and in preparation to
> implement them using generated_co_wrapper.
> 
> Callers were updated using this Coccinelle script:
> 
>     @@ expression child, offset, buf, bytes; @@
>     - bdrv_pread(child, offset, buf, bytes)
>     + bdrv_pread(child, offset, buf, bytes, 0)
> 
>     @@ expression child, offset, buf, bytes; @@
>     - bdrv_pwrite(child, offset, buf, bytes)
>     + bdrv_pwrite(child, offset, buf, bytes, 0)
> 
>     @@ expression child, offset, buf, bytes; @@
>     - bdrv_pwrite_sync(child, offset, buf, bytes)
>     + bdrv_pwrite_sync(child, offset, buf, bytes, 0)
> 
> Resulting overly-long lines were then fixed by hand.
> 
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/blklogwrites.c             |  4 +--
>  block/bochs.c                    |  6 ++--
>  block/cloop.c                    | 10 +++---
>  block/crypto.c                   |  4 +--
>  block/dmg.c                      | 24 +++++++-------
>  block/io.c                       | 13 ++++----
>  block/parallels-ext.c            |  4 +--
>  block/parallels.c                | 12 +++----
>  block/qcow.c                     | 27 ++++++++-------
>  block/qcow2-bitmap.c             | 14 ++++----
>  block/qcow2-cache.c              |  7 ++--
>  block/qcow2-cluster.c            | 21 ++++++------
>  block/qcow2-refcount.c           | 42 +++++++++++------------
>  block/qcow2-snapshot.c           | 39 +++++++++++-----------
>  block/qcow2.c                    | 44 ++++++++++++------------
>  block/qed.c                      |  8 ++---
>  block/vdi.c                      | 10 +++---
>  block/vhdx-log.c                 | 19 +++++------
>  block/vhdx.c                     | 32 ++++++++++--------
>  block/vmdk.c                     | 57 ++++++++++++++------------------
>  block/vpc.c                      | 19 ++++++-----
>  block/vvfat.c                    |  7 ++--
>  include/block/block-io.h         |  7 ++--
>  tests/unit/test-block-iothread.c |  8 ++---
>  24 files changed, 219 insertions(+), 219 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

signature.asc
Description: PGP signature