[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] hw/nvme: claim NVMe 2.0 compliance
|
From: |
Klaus Jensen |
|
Subject: |
Re: [PATCH v2 1/4] hw/nvme: claim NVMe 2.0 compliance |
|
Date: |
Tue, 28 Jun 2022 07:58:18 +0200 |
On Jun 27 10:59, Christoph Hellwig wrote:
> On Mon, Jun 27, 2022 at 01:47:28PM +0200, Niklas Cassel via wrote:
> > CRMS.CRWMS bit shall be set to 1 on controllers compliant with versions
> > later than NVMe 1.4.
> >
> > The first version later than NVMe 1.4 is NVMe 2.0
> >
> > Let's claim compliance with NVMe 2.0 such that a follow up patch can
> > set the CRMS.CRWMS bit.
> >
> > This is needed since CC.CRIME is only writable when both CRMS.CRIMS
> > and CRMS.CRWMS is set.
>
> You can also always support newer features without claiming
> compliance for the new version. I'd suggest to go through the
> mandatory changes list first before upgrading the compliance.
Agreed.
> (And one day it would be neat if someone tried to run the official
> but commercial compliance tests on qemu a well..)
Ouch!
signature.asc
Description: PGP signature