[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 09/21] jobs: use job locks also in the unit tests
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v10 09/21] jobs: use job locks also in the unit tests |
Date: |
Thu, 4 Aug 2022 13:56:57 +0200 |
Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben:
> Add missing job synchronization in the unit tests, with
> explicit locks.
>
> We are deliberately using _locked functions wrapped by a guard
> instead of a normal call because the normal call will be removed
> in future, as the only usage is limited to the tests.
>
> In other words, if a function like job_pause() is/will be only used
> in tests to avoid:
>
> WITH_JOB_LOCK_GUARD(){
> job_pause_locked();
> }
>
> then it is not worth keeping job_pause(), and just use the guard.
>
> Note: at this stage, job_{lock/unlock} and job lock guard macros
> are *nop*.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v10 09/21] jobs: use job locks also in the unit tests,
Kevin Wolf <=