[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 0/2] block: add missed block_acct_setup with new block device
From: |
Denis V. Lunev |
Subject: |
[PATCH v5 0/2] block: add missed block_acct_setup with new block device init procedure |
Date: |
Wed, 24 Aug 2022 11:50:42 +0200 |
Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from
the first glance, but it has changed things a lot. 'libvirt' uses it to
detect that it should follow new initialization way and this changes
things considerably. With this procedure followed, blockdev_init() is
not called anymore and thus block_acct_setup() helper is not called.
This means in particular that defaults for block accounting statistics
are changed and account_invalid/account_failed are actually initialized
as false instead of true originally.
This commit changes things to match original world. There are the following
constraints:
* new default value in block_acct_init() is set to true
* block_acct_setup() inside blockdev_init() is called before
blkconf_apply_backend_options()
* thus newly created option in block device properties has precedence if
specified
Changes from v4:
* removed hunk to QAPI which was used to test old initialization path
* added R-b: Vladimir
Changes from v3:
* fixed accidentally wrong submission. Contains changes which should be
sent as v3
Changes from v2:
* called bool_from_onoffauto(account_..., true) in the first patch to
preserve original semantics before patch 2
Changes from v1:
* set account_invalid/account_failed to true by default
* pass OnOffAuto to block_acct_init() to handle double initialization (patch 1)
* changed properties on BLK device to OnOffAuto
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Peter Krempa <pkrempa@redhat.com>
CC: Markus Armbruster <armbru@redhat.com>
CC: John Snow <jsnow@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Hanna Reitz <hreitz@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
- [PATCH v5 0/2] block: add missed block_acct_setup with new block device init procedure,
Denis V. Lunev <=