[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 47/50] block_job_query: remove atomic read
From: |
Kevin Wolf |
Subject: |
[PULL 47/50] block_job_query: remove atomic read |
Date: |
Fri, 7 Oct 2022 12:47:49 +0200 |
From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Not sure what the atomic here was supposed to do, since job.busy
is protected by the job lock. Since the whole function
is called under job_mutex, just remove the atomic.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20220926093214.506243-20-eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
blockjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockjob.c b/blockjob.c
index d04f804001..120c1b7ead 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -338,7 +338,7 @@ BlockJobInfo *block_job_query_locked(BlockJob *job, Error
**errp)
info = g_new0(BlockJobInfo, 1);
info->type = g_strdup(job_type_str(&job->job));
info->device = g_strdup(job->job.id);
- info->busy = qatomic_read(&job->job.busy);
+ info->busy = job->job.busy;
info->paused = job->job.pause_count > 0;
info->offset = progress_current;
info->len = progress_total;
--
2.37.3
- [PULL 16/50] copy-before-write: add missing coroutine_fn annotations, (continued)
- [PULL 16/50] copy-before-write: add missing coroutine_fn annotations, Kevin Wolf, 2022/10/07
- [PULL 29/50] job.c: make job_mutex and job_lock/unlock() public, Kevin Wolf, 2022/10/07
- [PULL 35/50] blockjob: introduce block_job _locked() APIs, Kevin Wolf, 2022/10/07
- [PULL 24/50] raw-format: add missing coroutine_fn annotations, Kevin Wolf, 2022/10/07
- [PULL 38/50] block/mirror.c: use of job helpers in drivers, Kevin Wolf, 2022/10/07
- [PULL 36/50] jobs: add job lock in find_* functions, Kevin Wolf, 2022/10/07
- [PULL 40/50] job: detect change of aiocontext within job coroutine, Kevin Wolf, 2022/10/07
- [PULL 50/50] file-posix: Remove unused s->discard_zeroes, Kevin Wolf, 2022/10/07
- [PULL 49/50] job: remove unused functions, Kevin Wolf, 2022/10/07
- [PULL 43/50] blockjob: rename notifier callbacks as _locked, Kevin Wolf, 2022/10/07
- [PULL 47/50] block_job_query: remove atomic read,
Kevin Wolf <=
- [PULL 46/50] job.c: enable job lock/unlock and remove Aiocontext locks, Kevin Wolf, 2022/10/07
- [PULL 45/50] job.h: categorize JobDriver callbacks that need the AioContext lock, Kevin Wolf, 2022/10/07
- [PULL 30/50] job.h: categorize fields in struct Job, Kevin Wolf, 2022/10/07
- [PULL 20/50] throttle: add missing coroutine_fn annotations, Kevin Wolf, 2022/10/07
- [PULL 34/50] job: move and update comments from blockjob.c, Kevin Wolf, 2022/10/07
- [PULL 41/50] jobs: protect job.aio_context with BQL and job_mutex, Kevin Wolf, 2022/10/07
- Re: [PULL 00/50] Block layer patches, Stefan Hajnoczi, 2022/10/12