Re: [PATCH v6 02/13] blkio: add libblkio block driver

[Stefan Hajnoczi]

On Fri, Oct 07, 2022 at 12:39:05PM +0200, Stefano Garzarella wrote:
> On Thu, Oct 06, 2022 at 05:34:56PM -0400, Stefan Hajnoczi wrote:
> > +    ret = blkio_get_int(s->blkio, "max-segments", &bs->bl.max_iov);
>                                                      ^
> Should we use `value` here, since we check it in next lines?
> 
> > +    if (ret < 0) {
> > +        error_setg_errno(errp, -ret, "failed to get \"max-segments\": %s",
> > +                         blkio_get_error_msg());
> > +        return;
> > +    }
> > +    if (value < 1) {
> > +        error_setg(errp, "invalid \"max-segments\" value %d, must be 
> > positive",
> > +                   bs->bl.max_iov);
>                      ^
> Ditto.

Yes, thanks for catching this.

signature.asc
Description: PGP signature