[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 06/43] hw/isa/piix3: Prefer pci_address_space() over get_syste
From: |
Bernhard Beschow |
Subject: |
[PATCH v2 06/43] hw/isa/piix3: Prefer pci_address_space() over get_system_memory() |
Date: |
Sat, 22 Oct 2022 17:04:31 +0200 |
get_system_memory() accesses global state while pci_address_space() uses
whatever has been passed to the device instance, so avoid the global.
Moreover, PIIX4 uses pci_address_space() here as well.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/isa/piix3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c
index 723ad0a896..0bea4aefe7 100644
--- a/hw/isa/piix3.c
+++ b/hw/isa/piix3.c
@@ -301,7 +301,7 @@ static void pci_piix3_realize(PCIDevice *dev, Error **errp)
PIIX3State *d = PIIX3_PCI_DEVICE(dev);
ISABus *isa_bus;
- isa_bus = isa_bus_new(DEVICE(d), get_system_memory(),
+ isa_bus = isa_bus_new(DEVICE(d), pci_address_space(dev),
pci_address_space_io(dev), errp);
if (!isa_bus) {
return;
--
2.38.1
- [PATCH v2 00/43] Consolidate PIIX south bridges, Bernhard Beschow, 2022/10/22
- [PATCH v2 01/43] hw/i386/pc: Create DMA controllers in south bridges, Bernhard Beschow, 2022/10/22
- [PATCH v2 03/43] hw/isa/piix3: Remove extra ';' outside of functions, Bernhard Beschow, 2022/10/22
- [PATCH v2 02/43] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge, Bernhard Beschow, 2022/10/22
- [PATCH v2 04/43] hw/isa/piix3: Add size constraints to rcr_ops, Bernhard Beschow, 2022/10/22
- [PATCH v2 05/43] hw/isa/piix3: Modernize reset handling, Bernhard Beschow, 2022/10/22
- [PATCH v2 06/43] hw/isa/piix3: Prefer pci_address_space() over get_system_memory(),
Bernhard Beschow <=
- [PATCH v2 07/43] hw/isa/piix4: Rename wrongly named method, Bernhard Beschow, 2022/10/22
- [PATCH v2 08/43] hw/ide/piix: Introduce TYPE_ macros for PIIX IDE controllers, Bernhard Beschow, 2022/10/22
- [PATCH v2 09/43] hw/usb/hcd-uhci: Introduce TYPE_ defines for device models, Bernhard Beschow, 2022/10/22
- [PATCH v2 10/43] hw/i386/pc: Create RTC controllers in south bridges, Bernhard Beschow, 2022/10/22
- [PATCH v2 11/43] hw/i386/pc: No need for rtc_state to be an out-parameter, Bernhard Beschow, 2022/10/22
- [PATCH v2 12/43] hw/isa/piix3: Create USB controller in host device, Bernhard Beschow, 2022/10/22
- [PATCH v2 13/43] hw/isa/piix3: Create power management controller in host device, Bernhard Beschow, 2022/10/22
- [PATCH v2 14/43] hw/intc/i8259: Introduce i8259 proxy "isa-pic", Bernhard Beschow, 2022/10/22