qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] block/blkio: Make driver nvme-io_uring take a "path" instead


From: Markus Armbruster
Subject: Re: [PATCH] block/blkio: Make driver nvme-io_uring take a "path" instead of a "filename"
Date: Sat, 29 Oct 2022 08:05:23 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Alberto Faria <afaria@redhat.com> writes:

> The nvme-io_uring driver expects a character special file such as
> /dev/ng0n1. Follow the convention of having a "filename" option when a
> regular file is expected, and a "path" option otherwise.

I suspect this is by accident, not by design.  Is it desirable?

> This makes io_uring the only libblkio-based driver with a "filename"
> option, as it accepts a regular file (even though it can also take a
> block special file).
>
> Signed-off-by: Alberto Faria <afaria@redhat.com>

Patch does not apply to master (344744e148e).  What's your base?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]