[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 27/32] monitor: Move monitor_putc() next to monitor_puts & extern
From: |
Markus Armbruster |
Subject: |
[PATCH 27/32] monitor: Move monitor_putc() next to monitor_puts & external linkage |
Date: |
Tue, 24 Jan 2023 13:19:41 +0100 |
monitor_putc() will soon be used from more than one .c file.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
include/monitor/monitor.h | 1 +
monitor/misc.c | 27 ---------------------------
monitor/monitor.c | 27 +++++++++++++++++++++++++++
3 files changed, 28 insertions(+), 27 deletions(-)
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
index 1e6f4c9bd7..033390f699 100644
--- a/include/monitor/monitor.h
+++ b/include/monitor/monitor.h
@@ -35,6 +35,7 @@ int monitor_puts(Monitor *mon, const char *str);
int monitor_vprintf(Monitor *mon, const char *fmt, va_list ap)
G_GNUC_PRINTF(2, 0);
int monitor_printf(Monitor *mon, const char *fmt, ...) G_GNUC_PRINTF(2, 3);
+void monitor_printc(Monitor *mon, int ch);
void monitor_flush(Monitor *mon);
int monitor_set_cpu(Monitor *mon, int cpu_index);
int monitor_get_cpu_index(Monitor *mon);
diff --git a/monitor/misc.c b/monitor/misc.c
index c531d95b5b..7a0ba35923 100644
--- a/monitor/misc.c
+++ b/monitor/misc.c
@@ -304,33 +304,6 @@ static void hmp_gdbserver(Monitor *mon, const QDict *qdict)
}
}
-static void monitor_printc(Monitor *mon, int c)
-{
- monitor_printf(mon, "'");
- switch(c) {
- case '\'':
- monitor_printf(mon, "\\'");
- break;
- case '\\':
- monitor_printf(mon, "\\\\");
- break;
- case '\n':
- monitor_printf(mon, "\\n");
- break;
- case '\r':
- monitor_printf(mon, "\\r");
- break;
- default:
- if (c >= 32 && c <= 126) {
- monitor_printf(mon, "%c", c);
- } else {
- monitor_printf(mon, "\\x%02x", c);
- }
- break;
- }
- monitor_printf(mon, "'");
-}
-
static void memory_dump(Monitor *mon, int count, int format, int wsize,
hwaddr addr, int is_physical)
{
diff --git a/monitor/monitor.c b/monitor/monitor.c
index 605fe41748..0a990633d8 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -259,6 +259,33 @@ int monitor_printf(Monitor *mon, const char *fmt, ...)
return ret;
}
+void monitor_printc(Monitor *mon, int c)
+{
+ monitor_printf(mon, "'");
+ switch(c) {
+ case '\'':
+ monitor_printf(mon, "\\'");
+ break;
+ case '\\':
+ monitor_printf(mon, "\\\\");
+ break;
+ case '\n':
+ monitor_printf(mon, "\\n");
+ break;
+ case '\r':
+ monitor_printf(mon, "\\r");
+ break;
+ default:
+ if (c >= 32 && c <= 126) {
+ monitor_printf(mon, "%c", c);
+ } else {
+ monitor_printf(mon, "\\x%02x", c);
+ }
+ break;
+ }
+ monitor_printf(mon, "'");
+}
+
/*
* Print to current monitor if we have one, else to stderr.
*/
--
2.39.0
- [PATCH 09/32] machine: Move QMP commands from monitor/ to hw/core/, (continued)
- [PATCH 09/32] machine: Move QMP commands from monitor/ to hw/core/, Markus Armbruster, 2023/01/24
- [PATCH 10/32] machine: Move HMP commands from monitor/ to hw/core/, Markus Armbruster, 2023/01/24
- [PATCH 20/32] tpm: Move HMP commands from monitor/ to softmmu/, Markus Armbruster, 2023/01/24
- [PATCH 28/32] monitor: Move target-dependent HMP commands to hmp-cmds-target.c, Markus Armbruster, 2023/01/24
- [PATCH 19/32] virtio: Move HMP commands from monitor/ to hw/virtio/, Markus Armbruster, 2023/01/24
- [PATCH 13/32] rocker: Move HMP commands from monitor to hw/net/rocker/, Markus Armbruster, 2023/01/24
- [PATCH 21/32] runstate: Move HMP commands from monitor/ to softmmu/, Markus Armbruster, 2023/01/24
- [PATCH 23/32] stats: Move HMP commands from monitor/ to stats/, Markus Armbruster, 2023/01/24
- [PATCH 27/32] monitor: Move monitor_putc() next to monitor_puts & external linkage,
Markus Armbruster <=
- [PATCH 30/32] monitor: Move remaining QMP stuff from misc.c to qmp-cmds.c, Markus Armbruster, 2023/01/24
- [PATCH 18/32] migration: Move the QMP command from monitor/ to migration/, Markus Armbruster, 2023/01/24
- [PATCH 32/32] monitor: Rename misc.c to hmp-target.c, Markus Armbruster, 2023/01/24
- [PATCH 29/32] monitor: Move remaining HMP commands from misc.c to hmp-cmds.c, Markus Armbruster, 2023/01/24
- [PATCH 15/32] net: Move HMP commands from monitor to net/, Markus Armbruster, 2023/01/24
- [PATCH 04/32] char: Factor out qmp_add_client() parts and move to chardev/, Markus Armbruster, 2023/01/24
- [PATCH 31/32] monitor: Loosen coupling between misc.c and monitor.c slightly, Markus Armbruster, 2023/01/24
- [PATCH 22/32] stats: Move QMP commands from monitor/ to stats/, Markus Armbruster, 2023/01/24
- [PATCH 12/32] block: Factor out hmp_change_medium(), and move to block/monitor/, Markus Armbruster, 2023/01/24