[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/7] python: QEMUMachine: enable qmp accept timeout by default
From: |
John Snow |
Subject: |
[PULL 2/7] python: QEMUMachine: enable qmp accept timeout by default |
Date: |
Tue, 24 Jan 2023 21:34:40 -0500 |
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
I've spent much time trying to debug hanging pipeline in gitlab. I
started from and idea that I have problem in code in my series (which
has some timeouts). Finally I found that the problem is that I've used
QEMUMachine class directly to avoid qtest, and didn't add necessary
arguments. Qemu fails and we wait for qmp accept endlessly. In gitlab
it's just stopped by timeout (one hour) with no sign of what's going
wrong.
With timeout enabled, gitlab don't wait for an hour and prints all
needed information.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20220624195252.175249-1-vsementsov@yandex-team.ru>
[Fixed typing. --js]
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/machine/machine.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index 748a0d807c9..c759db03e43 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -131,7 +131,7 @@ def __init__(self,
drain_console: bool = False,
console_log: Optional[str] = None,
log_dir: Optional[str] = None,
- qmp_timer: Optional[float] = None):
+ qmp_timer: Optional[float] = 30):
'''
Initialize a QEMUMachine
--
2.39.0
- [PULL 0/7] Python patches, John Snow, 2023/01/24
- [PULL 2/7] python: QEMUMachine: enable qmp accept timeout by default,
John Snow <=
- [PULL 4/7] python/qmp: increase read buffer size, John Snow, 2023/01/24
- [PULL 1/7] Fix some typos, John Snow, 2023/01/24
- [PULL 5/7] python/qmp/protocol: add open_with_socket(), John Snow, 2023/01/24
- [PULL 6/7] python/qmp/legacy: make QEMUMonitorProtocol accept a socket, John Snow, 2023/01/24
- [PULL 7/7] python/qemu/machine: use socketpair() for QMP by default, John Snow, 2023/01/24
- [PULL 3/7] python/machine: Fix AF_UNIX path too long on macOS, John Snow, 2023/01/24