[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 03/12] parallels: Fix image_end_offset and data_end after out
From: |
Alexander Ivanov |
Subject: |
[PATCH v10 03/12] parallels: Fix image_end_offset and data_end after out-of-image check |
Date: |
Fri, 3 Feb 2023 10:18:45 +0100 |
Set data_end to the end of the last cluster inside the image. In such a
way we can be sure that corrupted offsets in the BAT can't affect on the
image size. If there are no allocated clusters set image_end_offset by
data_end.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
---
block/parallels.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 436b36bbd9..2ed7cca249 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -488,7 +488,13 @@ static int coroutine_fn
parallels_co_check(BlockDriverState *bs,
}
}
- res->image_end_offset = high_off + s->cluster_size;
+ if (high_off == 0) {
+ res->image_end_offset = s->data_end << BDRV_SECTOR_BITS;
+ } else {
+ res->image_end_offset = high_off + s->cluster_size;
+ s->data_end = res->image_end_offset >> BDRV_SECTOR_BITS;
+ }
+
if (size > res->image_end_offset) {
int64_t count;
count = DIV_ROUND_UP(size - res->image_end_offset, s->cluster_size);
--
2.34.1
- [PATCH v10 00/12] parallels: Refactor the code of images checks and fix a bug, Alexander Ivanov, 2023/02/03
- [PATCH v10 02/12] parallels: Fix high_off calculation in parallels_co_check(), Alexander Ivanov, 2023/02/03
- [PATCH v10 03/12] parallels: Fix image_end_offset and data_end after out-of-image check,
Alexander Ivanov <=
- [PATCH v10 05/12] parallels: Use generic infrastructure for BAT writing in parallels_co_check(), Alexander Ivanov, 2023/02/03
- [PATCH v10 04/12] parallels: create parallels_set_bat_entry_helper() to assign BAT value, Alexander Ivanov, 2023/02/03
- [PATCH v10 07/12] parallels: Move check of cluster outside image to a separate function, Alexander Ivanov, 2023/02/03
- [PATCH v10 06/12] parallels: Move check of unclean image to a separate function, Alexander Ivanov, 2023/02/03
- [PATCH v10 12/12] parallels: Incorrect condition in out-of-image check, Alexander Ivanov, 2023/02/03
- [PATCH v10 10/12] parallels: Move statistic collection to a separate function, Alexander Ivanov, 2023/02/03
- [PATCH v10 09/12] parallels: Move check of leaks to a separate function, Alexander Ivanov, 2023/02/03
- [PATCH v10 08/12] parallels: Fix statistics calculation, Alexander Ivanov, 2023/02/03
- [PATCH v10 11/12] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD, Alexander Ivanov, 2023/02/03