[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] CI: Stop building docs on centos8
From: |
John Snow |
Subject: |
Re: [PATCH 6/7] CI: Stop building docs on centos8 |
Date: |
Thu, 9 Feb 2023 18:32:36 -0500 |
On Thu, Feb 9, 2023 at 5:43 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
>
> Il gio 9 feb 2023, 16:40 John Snow <jsnow@redhat.com> ha scritto:
>>
>> CentOS 8 does not ship with a sphinx new enough for our purposes (It
>> necessarily uses Python 3.6), so drop this from this build. We can
>> resume building docs on CentOS 9 if we wish, but we also currently test
>> and build docs on Fedora, Ubuntu, Alpine and Debian.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>
>
> It's possible to teach lcitool to use pip instead to install docutils, sphinx
> and sphinx-rtd-theme
> Once we can drop the previous patch this one can go as well; as soon as the
> last lcitool prerequisite is in
> (https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/341) I will pick the
> rest of this series, if that's okay for you.
OK - Dan requested extra version information in the commit message to
7, which I am researching a bit more exhaustively now. I can reply to
that patch with the requested info and if you'd like to pick 1-4 & 7,
you can be my guest.
I will say that once upon a time, Peter Maydell expressed a preference
to use the version(s) of sphinx managed by the distro instead of
swallowing it into the python-managed parts of the codebase. It seemed
like a reasonable request at the time. We can revisit it once I get
the patches in to add a venv at configure time. (Which I was intending
to visit next.)
>
> Paolo
>
- [PATCH 1/7] python: support pylint 2.16, (continued)
[PATCH 7/7] Python: Drop support for Python 3.6, John Snow, 2023/02/09
[PATCH 4/7] configure: Add nice hint to Python failure message, John Snow, 2023/02/09
[PATCH 5/7] testing: Add Python >= 3.7 to Centos, OpenSuSE, John Snow, 2023/02/09