|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [PATCH v2 04/14] tests: be a bit more strict cleaning up fifos |
| Date: | Tue, 21 Feb 2023 11:36:54 +0100 |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 |
On 21/2/23 10:45, Alex Bennée wrote:
When we re-factored we dropped the unlink() step which turns out to be required for rmdir to do its thing. If we had been checking the return value we would have noticed so lets do that with this fix. Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command) Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- tests/unit/test-io-channel-command.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Per v1 https://lore.kernel.org/qemu-devel/20230215192530.299263-5-alex.bennee@linaro.org/ Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com>
| [Prev in Thread] | Current Thread | [Next in Thread] |