[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 03/24] tests: be a bit more strict cleaning up fifos
From: |
Alex Bennée |
Subject: |
[PATCH v3 03/24] tests: be a bit more strict cleaning up fifos |
Date: |
Tue, 28 Feb 2023 19:06:32 +0000 |
When we re-factored we dropped the unlink() step which turns out to be
required for rmdir to do its thing. If we had been checking the return
value we would have noticed so lets do that with this fix.
Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230221094558.2864616-5-alex.bennee@linaro.org>
---
tests/unit/test-io-channel-command.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/unit/test-io-channel-command.c
b/tests/unit/test-io-channel-command.c
index 04b75ab3b4..c6e66a8c33 100644
--- a/tests/unit/test-io-channel-command.c
+++ b/tests/unit/test-io-channel-command.c
@@ -42,6 +42,7 @@ static void test_io_channel_command_fifo(bool async)
g_auto(GStrv) dstargv = g_strsplit(dstargs, " ", -1);
QIOChannel *src, *dst;
QIOChannelTest *test;
+ int err;
if (mkfifo(fifo, 0600)) {
g_error("mkfifo: %s", strerror(errno));
@@ -61,7 +62,10 @@ static void test_io_channel_command_fifo(bool async)
object_unref(OBJECT(src));
object_unref(OBJECT(dst));
- g_rmdir(tmpdir);
+ err = g_unlink(fifo);
+ g_assert(err == 0);
+ err = g_rmdir(tmpdir);
+ g_assert(err == 0);
}
static void test_io_channel_command_fifo_async(void)
--
2.39.2
- [PATCH v3 00/24] testing/next: docker, avocado, unit, gitlab, Alex Bennée, 2023/02/28
- [PATCH v3 01/24] tests: don't run socat tests on MacOS as well, Alex Bennée, 2023/02/28
- [PATCH v3 04/24] tests: make fp-test less chatty when running from test suite, Alex Bennée, 2023/02/28
- [PATCH v3 05/24] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs, Alex Bennée, 2023/02/28
- [PATCH v3 10/24] tests: add tuxrun baseline test to avocado, Alex Bennée, 2023/02/28
- [PATCH v3 03/24] tests: be a bit more strict cleaning up fifos,
Alex Bennée <=
- [PATCH v3 08/24] testing: update ubuntu2004 to ubuntu2204, Alex Bennée, 2023/02/28
- [PATCH v3 02/24] tests: add socat dependency for tests, Alex Bennée, 2023/02/28
- [PATCH v3 07/24] tests: don't run benchmarks for the tsan build, Alex Bennée, 2023/02/28
- [PATCH v3 06/24] gitlab: extend custom runners with base_job_template, Alex Bennée, 2023/02/28
- [PATCH v3 14/24] tests/dockerfiles: unify debian-toolchain references, Alex Bennée, 2023/02/28
- [PATCH v3 16/24] tests: Ensure TAP version is printed before other messages, Alex Bennée, 2023/02/28
- [PATCH v3 15/24] gitlab: Use plain docker in container-template.yml, Alex Bennée, 2023/02/28
- [PATCH v3 09/24] tests: skip the nios2 replay_kernel test, Alex Bennée, 2023/02/28
- [PATCH v3 12/24] tests: ensure we export job results for some cross builds, Alex Bennée, 2023/02/28
- [PATCH v3 11/24] tests/docker: Use binaries for debian-tricore-cross, Alex Bennée, 2023/02/28