[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/13] hw/xen: do not use aio_set_fd_handler(is_external=true
From: |
David Woodhouse |
Subject: |
Re: [PATCH 08/13] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore |
Date: |
Tue, 04 Apr 2023 10:52:32 +0100 |
User-agent: |
Evolution 3.44.4-0ubuntu1 |
On Mon, 2023-04-03 at 14:29 -0400, Stefan Hajnoczi wrote:
> There is no need to suspend activity between aio_disable_external() and
> aio_enable_external(), which is mainly used for the block layer's drain
> operation.
>
> This is part of ongoing work to remove the aio_disable_external() API.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Thanks.
> ---
> hw/i386/kvm/xen_xenstore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c
> index 900679af8a..6e81bc8791 100644
> --- a/hw/i386/kvm/xen_xenstore.c
> +++ b/hw/i386/kvm/xen_xenstore.c
> @@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error
> **errp)
> error_setg(errp, "Xenstore evtchn port init failed");
> return;
> }
> - aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), true,
> + aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh),
> false,
> xen_xenstore_event, NULL, NULL, NULL, s);
>
> s->impl = xs_impl_create(xen_domid);
smime.p7s
Description: S/MIME cryptographic signature
- [PATCH 00/13] block: remove aio_disable_external() API, Stefan Hajnoczi, 2023/04/03
- [PATCH 02/13] virtio-scsi: stop using aio_disable_external() during unplug, Stefan Hajnoczi, 2023/04/03
- [PATCH 05/13] block/export: wait for vhost-user-blk requests when draining, Stefan Hajnoczi, 2023/04/03
- [PATCH 06/13] block/export: stop using is_external in vhost-user-blk server, Stefan Hajnoczi, 2023/04/03
- [PATCH 03/13] block/export: only acquire AioContext once for vhost_user_server_stop(), Stefan Hajnoczi, 2023/04/03
- [PATCH 08/13] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore, Stefan Hajnoczi, 2023/04/03
- Re: [PATCH 08/13] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore,
David Woodhouse <=
- [PATCH 04/13] util/vhost-user-server: rename refcount to in_flight counter, Stefan Hajnoczi, 2023/04/03
- [PATCH 01/13] virtio-scsi: avoid race between unplug and transport event, Stefan Hajnoczi, 2023/04/03
- Re: [PATCH 01/13] virtio-scsi: avoid race between unplug and transport event, Michael S. Tsirkin, 2023/04/04
- [PATCH 09/13] hw/xen: do not set is_external=true on evtchn fds, Stefan Hajnoczi, 2023/04/03
- [PATCH 07/13] virtio: do not set is_external=true on host notifiers, Stefan Hajnoczi, 2023/04/03
- [PATCH 12/13] block/fuse: do not set is_external=true on FUSE fd, Stefan Hajnoczi, 2023/04/03