[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -b
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev |
Date: |
Tue, 4 Apr 2023 18:17:45 +0200 |
Am 04.04.2023 um 17:07 hat Michael Tokarev geschrieben:
> 04.04.2023 16:57, Kevin Wolf пишет:
> > Let's not make the use of -drive look more advisable than it really is.
> > If you're writing a management tool/script and you're still using -drive
> > today, you're doing it wrong.
>
> Kevin, maybe I'm wrong here, but what to do with the situation which
> started it all, -- with -snapshot?
>
> If anything, I think there should be a bold note that -snapshot is
> broken by -blockdev. Users are learning that the *hard* way, after
> losing their data..
Ah, I missed this context.
Maybe -snapshot should error out if -blockdev is in use. You'd generally
expect that either -blockdev is used primarily and snapshots are done
externally (if the command line is generated by some management tool),
or that -drive is used consistently (by a human who likes the
convenience). In both cases, we wouldn't hit the error path.
There may be some exceptional cases where you have both -drive and
-blockdev (maybe because a human users needs more control for one
specific disk). This is the case where you can get a nasty surprise and
that would error out. If you legitimately want the -drive images
snapshotted, but not the -blockdev ones, you can still use individual
'-drive snapshot=on' options instead of the global '-snapshot' (and the
error message should mention this).
Would you see any problems with such an approach?
Kevin
- [PATCH v2 00/11] more misc fixes for 8.0 (tests, gdbstub, meta, docs), Alex Bennée, 2023/04/03
- [PATCH v2 02/11] gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if necessary, Alex Bennée, 2023/04/03
- [PATCH v2 03/11] gdbstub: don't report auxv feature unless on Linux, Alex Bennée, 2023/04/03
- [PATCH v2 01/11] scripts/coverage: initial coverage comparison script, Alex Bennée, 2023/04/03
- [PATCH v2 04/11] MAINTAINERS: add a section for policy documents, Alex Bennée, 2023/04/03
- [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev, Alex Bennée, 2023/04/03
- Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev, Kevin Wolf, 2023/04/04
- Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev, Alex Bennée, 2023/04/04
- Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev, Michael Tokarev, 2023/04/04
- Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev,
Kevin Wolf <=
- Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev, Reinoud Zandijk, 2023/04/06
- Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev, Kevin Wolf, 2023/04/11
- Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev, Alex Bennée, 2023/04/11
[PATCH v2 06/11] metadata: add .git-blame-ignore-revs, Alex Bennée, 2023/04/03
[PATCH v2 07/11] Use hexagon toolchain version 16.0.0, Alex Bennée, 2023/04/03
[PATCH v2 09/11] tests/vm: use the default system python for NetBSD, Alex Bennée, 2023/04/03
[PATCH v2 08/11] tests/qemu-iotests: explicitly invoke 'check' via 'python', Alex Bennée, 2023/04/03
[PATCH v2 10/11] gitlab: fix typo, Alex Bennée, 2023/04/03
[PATCH v2 11/11] tests/avocado: Test Xen guest support under KVM, Alex Bennée, 2023/04/03