[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL for-8.0 1/2] hw/nvme: fix memory leak in fdp ruhid parsing
From: |
Klaus Jensen |
Subject: |
[PULL for-8.0 1/2] hw/nvme: fix memory leak in fdp ruhid parsing |
Date: |
Wed, 12 Apr 2023 12:04:35 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Coverity reports a memory leak of memory when parsing ruhids at
namespace initialization. Since this is just working memory, not needed
beyond the scope of the functions, fix this by adding a g_autofree
annotation.
Reported-by: Coverity (CID 1507979)
Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ns.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
index cfac960dcf39..547c0b154312 100644
--- a/hw/nvme/ns.c
+++ b/hw/nvme/ns.c
@@ -399,7 +399,8 @@ static bool nvme_ns_init_fdp(NvmeNamespace *ns, Error
**errp)
NvmeEnduranceGroup *endgrp = ns->endgrp;
NvmeRuHandle *ruh;
uint8_t lbafi = NVME_ID_NS_FLBAS_INDEX(ns->id_ns.flbas);
- unsigned int *ruhid, *ruhids;
+ g_autofree unsigned int *ruhids = NULL;
+ unsigned int *ruhid;
char *r, *p, *token;
uint16_t *ph;
--
2.39.2