[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/6] spec: Introduce NBD_FLAG_BLOCK_STATUS_PAYLOAD
From: |
Wouter Verhelst |
Subject: |
Re: [PATCH v3 5/6] spec: Introduce NBD_FLAG_BLOCK_STATUS_PAYLOAD |
Date: |
Tue, 18 Apr 2023 14:30:08 +0200 |
On Thu, Apr 13, 2023 at 05:02:40PM -0500, Eric Blake wrote:
[...]
> + If extended headers were negotiated, a server MAY optionally
> + advertise, via the transmission flag
> + `NBD_FLAG_BLOCK_STATUS_PAYLOAD`, that it supports an alternative
> + request form where the client sets `NBD_CMD_FLAG_PAYLOAD_LEN` in
> + order to pass a payload that informs the server to limit its
> + replies to the metacontext id(s) in the client's request payload,
> + rather than giving an answer on all possible metacontext ids. If
> + the server does not support the payload form, or detects duplicate
> + or unknown metacontext ids in the client's payload, the server
> + MUST gracefully consume the client's payload before failing with
> + `NBD_EINVAL`. The payload form MUST occupy 8 + n*4 bytes, where n
> + is the number of metacontext ids the client is interested in (as
> + implied by the payload length), laid out as:
> +
> + 64 bits, effect length
> + n * 32 bits, list of metacontext ids to use
This doesn't follow our usual format:
C: 64 bits, effect length
C: n * 32 bits, list of metacontext ids to use
Other than that,
Reviewed-By: Wouter Verhelst <w@uter.be>
--
w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}
I will have a Tin-Actinium-Potassium mixture, thanks.
[PATCH v3 2/6] spec: Change maximum block size to maximum payload size, Eric Blake, 2023/04/13
[PATCH v3 5/6] spec: Introduce NBD_FLAG_BLOCK_STATUS_PAYLOAD, Eric Blake, 2023/04/13
- Re: [PATCH v3 5/6] spec: Introduce NBD_FLAG_BLOCK_STATUS_PAYLOAD,
Wouter Verhelst <=
[PATCH v3 4/6] spec: Allow 64-bit block status results, Eric Blake, 2023/04/13
[PATCH v3 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length, Eric Blake, 2023/04/13
[PATCH v3 3/6] spec: Add NBD_OPT_EXTENDED_HEADERS, Eric Blake, 2023/04/13