[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/43] migration: Create migration_cap_set()
From: |
Juan Quintela |
Subject: |
Re: [PATCH v2 03/43] migration: Create migration_cap_set() |
Date: |
Thu, 20 Apr 2023 21:22:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Fabiano Rosas <farosas@suse.de> wrote:
> Juan Quintela <quintela@redhat.com> writes:
>
>> And remove the convoluted use of qmp_migrate_set_capabilities() to
>> enable disable MIGRATION_CAPABILITY_BLOCK.
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>> migration/migration.c | 34 ++++++++++++++++------------------
>> 1 file changed, 16 insertions(+), 18 deletions(-)
>>
>> diff --git a/migration/migration.c b/migration/migration.c
>> index 74f28cdca6..4bf5df4778 100644
>> --- a/migration/migration.c
>> +++ b/migration/migration.c
>> @@ -1913,25 +1913,24 @@ void migrate_set_state(int *state, int old_state,
>> int new_state)
>> }
>> }
>>
>> -static MigrationCapabilityStatus *migrate_cap_add(MigrationCapability index,
>> - bool state)
>> +static bool migrate_cap_set(int cap, bool value, Error **errp)
>
> Just a nit, the commit message says migration_cap_set.
Good catch. Fixed.
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
Thanks.
- [PATCH v2 00/43] Migration: Create options.c for capabilities/params/properties, Juan Quintela, 2023/04/20
- [PATCH v2 02/43] spice: move client_migrate_info command to ui/, Juan Quintela, 2023/04/20
- [PATCH v2 03/43] migration: Create migration_cap_set(), Juan Quintela, 2023/04/20
- [PATCH v2 01/43] migration: move migration_global_dump() to migration-hmp-cmds.c, Juan Quintela, 2023/04/20
- [PATCH v2 04/43] migration: Create options.c, Juan Quintela, 2023/04/20
- [PATCH v2 05/43] migration: Move migrate_colo_enabled() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 06/43] migration: Move migrate_use_compression() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 07/43] migration: Move migrate_use_events() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 09/43] migration: Move migrate_use_zero_copy_send() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 10/43] migration: Move migrate_use_xbzrle() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 08/43] migration: Move migrate_use_multifd() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 11/43] migration: Move migrate_use_block() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 12/43] migration: Move migrate_use_return() to options.c, Juan Quintela, 2023/04/20