|
From: | Juan Quintela |
Subject: | Re: [PATCH v2 07/16] qapi: Tidy up examples |
Date: | Tue, 25 Apr 2023 09:20:36 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> wrote: > A few examples neglect to prefix QMP input with '->'. Fix that. > > Two examples have extra space after '<-'. Delete it. > > A few examples neglect to show output. Provide some. The example > output for query-vcpu-dirty-limit could use further improvement. Add > a TODO comment. > > Use "Examples:" instead of "Example:" where multiple examples are > given. > > One example section numbers its two examples. Not done elsewhere; > drop. > > Another example section separates them with "or". Likewise. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |